Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MG-2403 - Add wrapper for policy CRUD #2402

Merged
merged 14 commits into from
Sep 4, 2024
Merged

MG-2403 - Add wrapper for policy CRUD #2402

merged 14 commits into from
Sep 4, 2024

Conversation

felixgateru
Copy link
Contributor

@felixgateru felixgateru commented Aug 28, 2024 •
edited
Loading

What type of PR is this?

This is a feature because it adds a wrapper for the polict grpc client.

What does this do?

This pr adds a wrapper for the policy grpc client and uses it in the things service.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@felixgateru felixgateru changed the title MG-2028 - Add wrapper for policy CRUD for things service MG-2403 - Add wrapper for policy CRUD Aug 29, 2024
@felixgateru felixgateru force-pushed the mg2028-auth branch 2 times, most recently from 4bf0eb3 to fa9f9d2 Compare August 29, 2024 16:14
@felixgateru felixgateru self-assigned this Aug 29, 2024
@felixgateru felixgateru marked this pull request as ready for review August 29, 2024 16:34
@felixgateru felixgateru changed the base branch from main to auth-middleware September 3, 2024 15:46
@felixgateru
feat: split auth client
d14bd6e 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: split auth cliet into authnz and policy clients
12a8079 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add tests
c4239da 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename clients
c7c2650 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
fix: fix property based tests
1f0c8cf 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor variable names to be more descriptive
a7e6126 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor log messages
ce5ee46 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename file pkg/auth to pkg/grpcclient
baa9909 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename things grpc service to authz service
0f786ab 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: refactor client type in adapters
e697bfb 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
feat: add policy CRUD warpper
c49c663 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
test: update tests
f57e1a2 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rename variables
beaa391 
Signed-off-by: 1998-felix <[email protected]>
@felixgateru
refactor: rebase
b829a45 
Signed-off-by: 1998-felix <[email protected]>
@dborovcanin dborovcanin merged commit 3faee6f into absmach:auth-middleware Sep 4, 2024
1 check failed
dborovcanin pushed a commit that referenced this pull request Sep 10, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
bbcb32d 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 12, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
c8c36d0 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 13, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
5fb971f 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 19, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
86a64da 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Sep 24, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
371ba3b 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Sep 25, 2024
@felixgateru @nyagamunene
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
eb357a0 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit to nyagamunene/magistrala that referenced this pull request Sep 27, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
40e8522 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Sep 30, 2024
@felixgateru
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
5880206 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 1, 2024
@felixgateru @nyagamunene
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
331966c 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 3, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
e3eb430 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 7, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
9d21ec2 
Signed-off-by: 1998-felix <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 7, 2024
@felixgateru @nyagamunene
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
47fbc58 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 8, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
c199d5e 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene pushed a commit to nyagamunene/magistrala that referenced this pull request Oct 8, 2024
@felixgateru @nyagamunene
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
29d0bf4 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 14, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
47e4546 
Signed-off-by: 1998-felix <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Oct 15, 2024
@felixgateru
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
d147fd4 
Signed-off-by: 1998-felix <[email protected]>
felixgateru added a commit that referenced this pull request Oct 15, 2024
@felixgateru
MG-2403 - Add wrapper for policy CRUD (#2402)
57647a7 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 15, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
afa07ef 
Signed-off-by: 1998-felix <[email protected]>
dborovcanin pushed a commit to dborovcanin/magistrala that referenced this pull request Oct 15, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
8045096 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
dborovcanin pushed a commit that referenced this pull request Oct 17, 2024
@felixgateru @dborovcanin
MG-2403 - Add wrapper for policy CRUD (#2402)
9ad30df 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
felixgateru added a commit to felixgateru/magistrala that referenced this pull request Oct 24, 2024
@felixgateru
MG-2403 - Add wrapper for policy CRUD (absmach#2402)
8598e71 
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: Dusan Borovcanin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dborovcanin dborovcanin dborovcanin approved these changes

Assignees

@felixgateru felixgateru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a wrapper for PolicyCRUD that currently communicates with the Auth service.
2 participants
@felixgateru @dborovcanin