NOISSUE - Add Readers and Consumers SDK #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
noissue-readersSDK
branch
5 times, most recently
from
d39b9b0 to
fe9a2ee
Compare
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
felixgateru
force-pushed
the
noissue-readersSDK
branch
from
fe9a2ee to
3c24d99
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
===========================================
+ Coverage 23.93% 55.43% +31.50%
===========================================
Files 79 61 -18
Lines 12433 5334 -7099
===========================================
- Hits 2976 2957 -19
+ Misses 9116 2049 -7067
+ Partials 341 328 -13 ☔ View full report in Codecov by Sentry. |
dborovcanin
requested changes
Jan 11, 2025
| // Notifier represents an API for sending notification. | ||
| // | ||
| //go:generate mockery --name Notifier --output=./mocks --filename notifier.go --quiet --note "Copyright (c) Abstract Machines" | ||
| type Notifier interface { |
There was a problem hiding this comment.
It's OK to keep the Notifier service (CRUD for Subscriptions) in Magistrala, but please move the Notifier interface to SuperMQ /consumers package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds Readers and Consumers SDK.
What does this do?
This pr adds the Readers and consumer sdk files as well as respective tests.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes
Related to pr: absmach/supermq#2641