NOISSUE - Add DTLS support to CoAP messaging #1909
Conversation
felixgateru
changed the title
internal/server/coap/coap.go
Outdated
| @@ -21,6 +22,8 @@ type Server struct { | |||
| handler mux.HandlerFunc | |||
| } | |||
|
|
|||
| var enableDTLS = true | |||
There was a problem hiding this comment.
use env var to pass this
internal/server/coap/coap.go
Outdated
| @@ -21,6 +22,8 @@ type Server struct { | |||
| handler mux.HandlerFunc | |||
| } | |||
|
|
|||
| var enableDTLS = true | |||
There was a problem hiding this comment.
use env var to pass this
| @@ -55,6 +58,22 @@ func (s *Server) Start() error { | |||
| go func() { | |||
There was a problem hiding this comment.
this should be the default case in line 78
felixgateru
force-pushed
the
coap_dtls
branch
2 times, most recently
from
fdf4654 to
908e596
Compare
| @@ -24,6 +27,8 @@ type Server struct { | |||
| handler mux.HandlerFunc | |||
| } | |||
|
|
|||
|
|
|||
| } | ||
|
|
||
| go func() { | ||
| errCh <- gocoap.ListenAndServeTCPTLS("udp", s.Address, tlsConfig, s.handler) | ||
| errCh <- gocoap.ListenAndServeDTLS("udp", s.Address, dtlsConfig, s.handler) |
There was a problem hiding this comment.
why is ListenTCP removed, we shoulld have all 3 options, no TLS, TLS and DTLS. Modify the config file and this
docker/nginx/nginx-key.conf
Outdated
| @@ -161,4 +161,22 @@ stream { | |||
| } | |||
| } | |||
|
|
|||
| # COAP | |||
docker/nginx/nginx-x509.conf
Outdated
| @@ -151,4 +151,31 @@ stream { | |||
| } | |||
| } | |||
|
|
|||
| #COAP | |||
There was a problem hiding this comment.
CoAP, and add space after the #
felixgateru
force-pushed
the
coap_dtls
branch
from
908e596 to
d68c3b0
Compare
docker/nginx/nginx-x509.conf
Outdated
| @@ -151,4 +151,31 @@ stream { | |||
| } | |||
| } | |||
|
|
|||
| #CoAP | |||
There was a problem hiding this comment.
Put a space after the # comment, I have already demanded this.
|
|
||
| upstream coap_cluster { | ||
| server coap-adapter:${MF_COAP_ADAPTER_HTTP_PORT}; | ||
| } |
There was a problem hiding this comment.
Add an empty line to the end of the file.
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| upstream coap_cluster { | ||
| server coap-adapter:${MF_COAP_ADAPTER_HTTP_PORT}; |
There was a problem hiding this comment.
This is just CoAP port, not CoAP HTTP port (HTTP is used only for healthcheck).
felixgateru
force-pushed
the
coap_dtls
branch
2 times, most recently
from
4c6a6c4 to
0e4b393
Compare
|
LGTM In Future it will nice if coap server have CID support Reference code for ID |
dborovcanin
force-pushed
the
coap_dtls
branch
from
0e4b393 to
ca3976c
Compare
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: 1998-felix <[email protected]>
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: felix.gateru <[email protected]>
Signed-off-by: felix.gateru <[email protected]>
What does this do?
Add DTLS support to CoAP messaging
Which issue(s) does this PR fix/relate to?
None
List any changes that modify/break current functionality
Refactor: Updated the nginx reverse proxy with CoAP stream.
Refactor: Add internal server configuration for DTLS support.
Have you included tests for your changes?
No
Did you document any new/modified functionality?
No
Notes
To be merged after https://github.com/mainflux/mainflux/pull/1918