refactor: broadly refactor Vault client #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit broadly refactors the Vault backend to improve K/V lookup for both V1 and V2 KVs. It properly leverages the `prefix` configuration for the Secrets Engine path and accomodates the differences between the KV v1 and KV v2 endpoints, specifically the use of `data` in the secret path. This returns the Vault backend back to pathing parity with the other backends. It also means this commit is a breaking change and is not backwards compatible with configurations that use the more explicit pathing. This commit also resolves issue #244
abtreece
force-pushed
the
refactor-vault-backend
branch
from
7c677e3 to
780a399
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #270 +/- ##
===========================================
- Coverage 34.23% 15.59% -18.64%
===========================================
Files 7 19 +12
Lines 669 1706 +1037
===========================================
+ Hits 229 266 +37
- Misses 386 1384 +998
- Partials 54 56 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit broadly refactors the Vault backend to improve K/V lookup for both V1 and V2 KVs. It properly leverages the
prefixconfiguration for the Secrets Engine path and accomodates the differences between the KV v1 and KV v2 endpoints, specifically the use ofdatain the secret path. This returns the Vault backend back to pathing parity with the other backends. It also means this commit is a breaking change and is not backwards compatible with configurations that use the more explicit pathing.This commit also resolves issue #244