Pla 991 fix radio box styling issues #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 29, 2024 21:31
mnlfischer
reviewed
Jan 30, 2024
| className, | ||
| }: RadioBoxOptionProps) => { | ||
| const Title = ({ children }: { children: React.ReactNode }) => ( | ||
| <h2 className="headline-500 text-neutral-900 group-[.is-checked]:text-neutral-0 group-[.is-disabled]:text-neutral-500"> |
There was a problem hiding this comment.
Maybe this works here too:
group-ui-checked:
Also for other implementations in your MR :)
Ress: https://github.com/tailwindlabs/headlessui/tree/main/packages/%40headlessui-tailwindcss#documentation
There was a problem hiding this comment.
I’ve tested or tried this already, but unfortunately this doesn’t work for non-option-html-elements. The radio boxes needs to render div elements which aren’t supporting css check and active states (at least for groups). The element isn’t working here, because we need to render more complex children than just strings :-)
mnlfischer
approved these changes
Jan 30, 2024
|
🎉 This PR is included in version 3.14.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This mr adds a breaking change to radio boxes and adds some styling fixes to match the new design