Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: split button/link component and support asChild for links #116

Merged
merged 1 commit into from
Mar 12, 2024
Merged

BREAKING CHANGE: split button/link component and support asChild for links #116

merged 1 commit into from
Mar 12, 2024

Conversation

mnlfischer
Copy link
Collaborator

Description

  • split Button/Link component into two independent components
  • support asChild prop for links (e.g. Next/Link can be used now)

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@mnlfischer mnlfischer self-assigned this Mar 8, 2024
@linear Linear
Copy link

linear bot commented Mar 8, 2024

PLA-1066 Split Link and Button into two separate components

Coderwelsch
Coderwelsch approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Coderwelsch Coderwelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@mnlfischer mnlfischer merged commit aebd74c into main Mar 12, 2024
7 checks passed
@mnlfischer mnlfischer deleted the pla-1066-split-link-and-button-into-two-separate-components branch March 12, 2024 12:22
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Coderwelsch Coderwelsch Coderwelsch approved these changes

Assignees

@mnlfischer mnlfischer

Labels
released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnlfischer @abusix-bot @Coderwelsch