Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render passed children in tooltip parent #151

Merged

Conversation

mnlfischer
Copy link
Collaborator

@mnlfischer mnlfischer commented Sep 25, 2024

Description

Instead of rendering a div around the child that causes layout issues, we now rendering the passed children with the ref for popper.

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@mnlfischer mnlfischer self-assigned this Sep 25, 2024
Copy link

linear bot commented Sep 25, 2024

Copy link
Contributor

@pallendes pallendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mnlfischer mnlfischer merged commit 84cf284 into main Sep 25, 2024
7 checks passed
@mnlfischer mnlfischer deleted the pla-1402-hailstorm-remove-wrapping-div-for-tooltip-component branch September 25, 2024 09:26
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 5.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants