Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): add badge test #41

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

mnlfischer
Copy link
Collaborator

@mnlfischer mnlfischer commented Sep 26, 2023

Description

This PR adds a test to the badge component. It covers string representation and component shape.

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@mnlfischer mnlfischer requested review from a team and Coderwelsch and removed request for a team September 26, 2023 07:25
@rodelta
Copy link
Collaborator

rodelta commented Sep 26, 2023

Test looks good.
I went into the pipeline and I only see one test running, so you might want to have a look at the script that's runnning the tests.
CleanShot 2023-09-26 at 15 06 52

@mnlfischer
Copy link
Collaborator Author

@rodelta I fixed the action to run the lastest code from the pr. Now the new test getting picked up 👍🏻

@mnlfischer mnlfischer merged commit 797c941 into main Sep 27, 2023
4 checks passed
@mnlfischer mnlfischer deleted the pla-507-hailstorm-component-tests-badge branch September 27, 2023 11:38
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants