Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-combobox-options): Add z-index to multicombobox options #43

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

pallendes
Copy link
Contributor

Description

Added z-index to multi-combobox options to fix the issue shown in the image:

image

Checklist

  • Change increases quality
  • Change is validated by tests
  • Change is readable and easy to understand
  • Documentation is updated
  • Security impact has been considered
  • Changes validated in runtime

@pallendes pallendes self-assigned this Sep 27, 2023
@mnlfischer
Copy link
Collaborator

Instead of adding a z-index to the component that can vary for each implementation, the better option here is to add a className prop for the options component. That reduces the risk of changing it again, when the index needs to be increased because the underlaying component has already a z-index 10. With the className prop the user can edit it to the correct index. @pallendes please share your thoughts on it.

@pallendes pallendes force-pushed the add-z-index-to-multicombobox-options branch from b1d8e4a to 7e0a5af Compare September 27, 2023 07:14
@pallendes
Copy link
Contributor Author

Instead of adding a z-index to the component that can vary for each implementation, the better option here is to add a className prop for the options component. That reduces the risk of changing it again, when the index needs to be increased because the underlaying component has already a z-index 10. With the className prop the user can edit it to the correct index. @pallendes please share your thoughts on it.

Yep, that I like even more. I've made the changes 🙂

@pallendes pallendes merged commit 7b23c10 into main Sep 27, 2023
3 checks passed
@pallendes pallendes deleted the add-z-index-to-multicombobox-options branch September 27, 2023 12:34
@abusix-bot
Copy link
Collaborator

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants