Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev lukas #301

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Dev lukas #301

merged 3 commits into from
Sep 5, 2023

Conversation

aut0
Copy link
Collaborator

@aut0 aut0 commented Aug 8, 2023

No description provided.

@aut0 aut0 requested a review from barnasc August 8, 2023 15:15
@aut0 aut0 self-assigned this Aug 8, 2023
@aut0 aut0 force-pushed the dev-lukas branch 2 times, most recently from 7e5506d to 4b7b901 Compare August 9, 2023 16:18
@aut0
Copy link
Collaborator Author

aut0 commented Aug 9, 2023

@barnasc I updated the file as discussed in the meeting. It's ready for review.

Copy link
Contributor

@barnasc barnasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review comments inline

RELEASENOTES.md Outdated Show resolved Hide resolved
docs/DEVELOPMENT.md Show resolved Hide resolved
@barnasc
Copy link
Contributor

barnasc commented Aug 10, 2023

additional thing seen during regression in the automake flow:

No rule to make target 'ChangeLog', needed by 'all-am'. Stop.

We need to delete this ChangeLog entry in Makefile.am

Align the supported platforms with the SystemC reference implementation.
Remove formerly supported platforms.
Update information on SystemC version to 2.3.3 and following.

Signed-off-by: Lukas Jünger <[email protected]>
Signed-off-by: Lukas Jünger <[email protected]>
Update to DEVELOPMENT.md to reflect the automatic creation of release
tarballs through GitHub Actions.

Signed-off-by: Lukas Jünger <[email protected]>
@aut0
Copy link
Collaborator Author

aut0 commented Aug 24, 2023

additional thing seen during regression in the automake flow:

No rule to make target 'ChangeLog', needed by 'all-am'. Stop.

We need to delete this ChangeLog entry in Makefile.am

Done

@aut0 aut0 assigned barnasc and unassigned aut0 Aug 24, 2023
@barnasc
Copy link
Contributor

barnasc commented Sep 5, 2023

approved. Can be merged

@aut0 aut0 merged commit f84266f into accellera-official:master Sep 5, 2023
54 of 66 checks passed
@aut0 aut0 deleted the dev-lukas branch September 8, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants