feat(alias import): modelfile.js alias imports handled

- alias types mapped to fqn in the importShortNames Signed-off-by: Jaskeerat Singh Saluja <[email protected]>
accordproject · Jun 20, 2024 · 4d26b39 · 4d26b39
1 parent 09f6b04
commit 4d26b39
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 4 deletions.
diff --git a/packages/concerto-core/lib/basemodelmanager.js b/packages/concerto-core/lib/basemodelmanager.js
@@ -124,6 +124,14 @@ class BaseModelManager {
         return this.strict;
     }
 
+    /**
+     * Returns the value of the enableAliasedType option
+     * @returns {boolean} true if the enableAliasedType has been set
+     */
+    isAliasedTypeEnabled() {
+        return this.enableAliasedType;
+    }
+
     /**
      * Adds root types
      * @private

diff --git a/packages/concerto-core/lib/introspect/modelfile.js b/packages/concerto-core/lib/introspect/modelfile.js
@@ -219,7 +219,7 @@ class ModelFile extends Decorated {
      */
     validate() {
         super.validate();
-
+        // TODO
         // A dictionary of imports to versions to track unique namespaces
         const importsMap = new Map();
 
@@ -752,9 +752,24 @@ class ModelFile extends Decorated {
                 this.importWildcardNamespaces.push(imp.namespace);
                 break;
             case `${MetaModelNamespace}.ImportTypes`:
-                imp.types.forEach( type => {
-                    this.importShortNames.set(type, `${imp.namespace}.${type}`);
-                });
+                if (this.getModelManager().isAliasedTypeEnabled()) {
+                    // map: alias name to the fqn's
+                    // imp.types and imp.aliasedTypes both are available
+                    let aliasedTypes = new Map();
+                    if (imp.aliasedTypes) {
+                        imp.aliasedTypes.forEach(({ name, aliasName }) => {
+                            aliasedTypes.set(name, aliasName);
+                        });
+                    }
+                    imp.types.forEach((type)=> aliasedTypes.has(type)? this.importShortNames.set(aliasedTypes[type],`${imp.namespace}.${type}`):this.importShortNames.set(type,`${imp.namespace}.${type}`));
+                } else {
+                    if (imp.aliasedTypes) {
+                        throw new Error('Aliasing disabled, set enableAliasType to true');
+                    }
+                    imp.types.forEach((type) => {
+                        this.importShortNames.set(type,`${imp.namespace}.${type}`);
+                    });
+                }
                 break;
             default:
                 this.importShortNames.set(imp.name, ModelUtil.importFullyQualifiedNames(imp)[0]);