Lupl/add mypy action #214
Open
Lupl/add mypy action #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration was done using https://github.com/mkniewallner/migrate-to-uv. FastAPI should be installed using '--extra standard' with uv. See https://docs.astral.sh/uv/guides/integration/fastapi/.
Note: I decided to generally exclude pandas from mypy checking because pandas stubs are not in typeshed and pandas chooses to do its own separate stub project.
lu-pl
force-pushed
the
lupl/add-mypy-action
branch
3 times, most recently
from
de95bb2 to
fe94f46
Compare
Note that _get_model_bool_predicate_from_config_value technically takes Any and performs runtime type checking with a a wildcard clause. _TmodelBoolValue is the /intended/ type however and the type hint should reflect that. Also linters will suggest the intended type then. This means that a type cast in get_model_predicate is necessary though.
The setting is non-strict for now.
lu-pl
force-pushed
the
lupl/add-mypy-action
branch
from
fe94f46 to
1c2b028
Compare
kevinstadler
approved these changes
Feb 6, 2025
lu-pl
force-pushed
the
lupl/add-mypy-action
branch
from
1c2b028 to
49946a3
Compare
kevinstadler
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133.