Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #238

Merged
merged 4 commits into from
Feb 3, 2025
Merged

Performance improvements #238

merged 4 commits into from
Feb 3, 2025

Conversation

katharinawuensche
Copy link
Member

This branch

  • replaces the column filters in Wibarab with Maps instead of Arrays
  • uses shallowRefs in the pinia stores (geojson store and colors store)
  • rewrites the nearby marker computation logic to use a dynamically sized grid and reduce the number of computations per marker (revise/refactor "nearby markers" computation #207)

ctot-nondef
ctot-nondef approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@ctot-nondef ctot-nondef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @katharinawuensche ! dynamic grid cells are a great idea

@ctot-nondef ctot-nondef merged commit 7d75837 into develop Feb 3, 2025
7 of 11 checks passed
@ctot-nondef ctot-nondef deleted the fix/wibarab-performance-improvements branch February 3, 2025 08:42
@ctot-nondef
Copy link
Member

deployment fails d/t / in branch name - @simar0at is there something we can do about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctot-nondef ctot-nondef ctot-nondef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katharinawuensche @ctot-nondef