Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the February 2024 Newsletter #458

Merged
merged 5 commits into from
May 6, 2024

Conversation

YoshithaRathnayake
Copy link
Member

@YoshithaRathnayake YoshithaRathnayake commented May 6, 2024

Purpose

The purpose of this PR is to add #February2024Newsletter

Goals

Adding the february 2024 newsletter

Approach

Added the february 2024 newsletter

Screenshots

image

Preview Link

https://pr-458-sack-site-acf.surge.sh/newsletter

Checklist

  • This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
  • I have read and understood the development best practices guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Related PRs

Test environment

Learning

Copy link
Collaborator

@Hasthikagirihagama Hasthikagirihagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice And Great work @YoshithaRathnayake. Can we add A small change in the Footer regarding mentioning the name, since it is for the school site we normally don't add the contributors in the footer. But We could add another page linking to a page named "Credits", it would be much official. Anyhow other than that once again Nice work❤️🥳🙌

@Hasthikagirihagama Hasthikagirihagama merged commit ede4781 into acf-sack:master May 6, 2024
1 check passed
@YoshithaRathnayake YoshithaRathnayake deleted the newsletter branch May 6, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants