Skip to content

Commit

Permalink
update CONTRIBUTING.md
Browse files Browse the repository at this point in the history
  • Loading branch information
acheronfail committed Apr 16, 2024
1 parent fae1a39 commit fae19b9
Showing 1 changed file with 18 additions and 12 deletions.
30 changes: 18 additions & 12 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
# Tips

## Nerd Fonts
# Hacking on i3stat

Nerd Font icons come in two variants. If the font was called "A", the the variants are:

* "A Nerd Font"
* "A Nerd Font Mono"
* All new development is done on the `next` branch! Don't target `master`!
* Run the tests with `just` (not via `cargo`)
* Read the rest of this file!

The one with the "Mono" suffix has all the icons 'squashed' into a single monospace character's width.
This is a compatibility for programs that don't support double-width characters, but does make some of the icons appear too small.

Unfortunately, as far as I can tell, i3's statusbar doesn't properly support the double-width character icons.
So, if the normal font is used, sometimes the icons appear to overlap neighbouring characters.
# Tips

## Debugging integration tests

Expand All @@ -26,6 +19,19 @@ It's a cheaper method of keeping immutable data around without having to realloc
Since mutating the data isn't necessary, this can just point the the existing data and we get cheap clones.
See https://www.youtube.com/watch?v=A4cKi7PTJSs for a good explanation.

## Nerd Fonts

Nerd Font icons come in two variants. If the font was called "A", the the variants are:

* "A Nerd Font"
* "A Nerd Font Mono"

The one with the "Mono" suffix has all the icons 'squashed' into a single monospace character's width.
This is a compatibility for programs that don't support double-width characters, but does make some of the icons appear too small.

Unfortunately, as far as I can tell, i3's statusbar doesn't properly support the double-width character icons.
So, if the normal font is used, sometimes the icons appear to overlap neighbouring characters.

# Creating the next release

All new development is done on the `next` branch. When it's time to make a release, a PR is created to `master`.
Expand Down

0 comments on commit fae19b9

Please sign in to comment.