Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all clippy warnings #28

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Fixed all clippy warnings #28

merged 3 commits into from
Apr 16, 2024

Conversation

maxleiko
Copy link

Just a full clean of the master branch to get rid of clippy warnings.

Note that I did not manage to run the test locally (even using just) so I'm hoping the PR will trigger them properly on the CI.

@acheronfail
Copy link
Owner

Just looked over all these changes, and wow - I'm impressed. Clippy has come a long way since I used it last!
I should probably add clippy to CI, so these things don't creep up on us again.

Huge thank you for doing this.

Looks like my CI has an error, I'll try to fix that and get CI going on this one.

@acheronfail acheronfail changed the base branch from master to next April 16, 2024 04:43
@acheronfail acheronfail changed the base branch from next to master April 16, 2024 04:47
@acheronfail
Merge remote-tracking branch 'origin/master' into maxleiko-pedantic
8154154 
* origin/master:
  add path for aarch64 faketime on debian
  add --locked to stop CI from breaking unexpectedly
  justfile: update repositories before installing dependencies
  battery: fix bug when autodetecting batteries
  rename sensors item "label" to "component" to add a label option
  remove unneeded dbg!
  update justfile for fedora distributions
  battery: fallback to capacity if charge_* missing
@acheronfail
Copy link
Owner

acheronfail commented Apr 16, 2024 •
edited
Loading

Note that I did not manage to run the test locally (even using just) so I'm hoping the PR will trigger them properly on the CI.

Are you by chance using Wayland? I did just discover that because it runs nested X sessions for XWayland windows, there's usually already an X server using :1 as the display (my local tests assumed :1 was available). I updated it to :42 for now as a quick workaround, should work for you now if that was the issue. actually that was just for just debug not just test... I wonder what your issue was. 🤔

@acheronfail acheronfail merged commit 0c17fb5 into acheronfail:master Apr 16, 2024
2 checks passed
@maxleiko
Copy link
Author

Are you by chance using Wayland?

No I'm not. Still good ol' X11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxleiko @acheronfail