Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSD v0.1.0-beta - Adds spacing array to the theme definitions #76

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

jongomez
Copy link
Contributor

@jongomez jongomez commented Oct 11, 2023

Adds spacing values to the theme definitions. New CSS global vars are create for spacing. We can then use these CSS vars like so:

margin-left: var(--lsd-spacing-120);

Figma link

Notion link

Note regarding the figma desings:

  • There are 2 sections on the figma designs - the primitives and the tokens. The default values I'm currently using are the ones from the tokens section. I can change this is anyone thinks it makes sense.

How to test this

  • I didn't create a storybook file for this, as it's not a component (I can create 1 if people think it makes sense). I tested by going to a component styles file, and changing the css to include any of the new spacing vars, like I mentioned above for example: margin-left: var(--lsd-spacing-120);

@jeangovil
Copy link
Contributor

Thanks @jongomez, regarding the storybook, I'll create a page for the theme provider and design tokens as a part of #72

@jongomez jongomez merged commit efa4792 into main Oct 11, 2023
3 of 6 checks passed
@jongomez jongomez deleted the spacing-theme-vars branch October 11, 2023 13:36
@jongomez jongomez mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants