Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chat_linker.dsc #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jumpsplat120
Copy link

Messages that contain {main_hand}, {off_hand}, {boots}, {leggings}, {chestplate} or {helmet} will instead replace the bracketed text with the item in the corresponding slot.

Show off your cool stuff to all your friends!

Messages that contain `{main_hand}`, `{off_hand}`, `{boots}`, `{leggings}`, `{chestplate}` or `{helmet}` will instead replace the bracketed text with the item in the corresponding slot.

Show off your cool stuff to all your friends!
- foreach <[items]> as:item:
- define display <[item].display.if_null[<[item].material.translated_name>].on_hover[<[item]>].type[SHOW_ITEM]>
- define message <[message].replace_text[{<[key]>}].with[<[display].underline>]>
- determine <[message]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How will this look on discord?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Janky, it'll look like Denizen text formatting, so we have to account for that. Like §[hover=SHOW_ITEM;i@wooden_sword]§[translate=item.minecraft.wooden_sword]§[/hover] How are we currently handling Denizen text formatting?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a great question for @acikek

Copy link
Owner

@acikek acikek Feb 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not yet handling it at all. The raw message gets sent to the bridge channel.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this is a good point to bring up the task idea we were talking about before. Along with the task passing in all the contexts, we could also have the task pass in a is_bridge boolean, and then allow the task to handle it separately. So, for the chat linker example, if is_bridge is false, then it basically function as written, and is_bridge is true, then it maybe replaces the item with only the display name or something, rather than doing the full SHOW_ITEM.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add strip_color to the chat bridge, it'll translate translatables, remove hovers, etc.

@funkychicken493
Copy link
Contributor

Hey maybe this should be put in a chat folder rather than a personal one? I'm not sure if this violates a formatting rule or something. @acikek

@acikek
Copy link
Owner

acikek commented Feb 3, 2023

Hey maybe this should be put in a chat folder rather than a personal one? I'm not sure if this violates a formatting rule or something. @acikek

I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants