-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create chat_linker.dsc #18
base: main
Are you sure you want to change the base?
Conversation
Messages that contain `{main_hand}`, `{off_hand}`, `{boots}`, `{leggings}`, `{chestplate}` or `{helmet}` will instead replace the bracketed text with the item in the corresponding slot. Show off your cool stuff to all your friends!
- foreach <[items]> as:item: | ||
- define display <[item].display.if_null[<[item].material.translated_name>].on_hover[<[item]>].type[SHOW_ITEM]> | ||
- define message <[message].replace_text[{<[key]>}].with[<[display].underline>]> | ||
- determine <[message]> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this look on discord?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Janky, it'll look like Denizen text formatting, so we have to account for that. Like §[hover=SHOW_ITEM;i@wooden_sword]§[translate=item.minecraft.wooden_sword]§[/hover]
How are we currently handling Denizen text formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a great question for @acikek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not yet handling it at all. The raw message gets sent to the bridge channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this is a good point to bring up the task
idea we were talking about before. Along with the task passing in all the contexts, we could also have the task pass in a is_bridge
boolean, and then allow the task to handle it separately. So, for the chat linker example, if is_bridge
is false, then it basically function as written, and is_bridge
is true, then it maybe replaces the item with only the display name or something, rather than doing the full SHOW_ITEM
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add strip_color
to the chat bridge, it'll translate translatables, remove hovers, etc.
Hey maybe this should be put in a |
I agree. |
Messages that contain
{main_hand}
,{off_hand}
,{boots}
,{leggings}
,{chestplate}
or{helmet}
will instead replace the bracketed text with the item in the corresponding slot.Show off your cool stuff to all your friends!