fix(#1205): deprem io response fix

[absolutezero13]

Description

• I've changed replaceAll function to replace because node v14 doesn't support replaceAll. Parser was crashing on the server side because of this.
• I've added fizikiDurum property for the description as it looks like the most suitable to me. But we can change it, since the bigger problem is solved, that's why I wanted to create this PR.

discord username: afetharita#0001

closes #issue #1205 #1210

Please describe your changes. Also describe your aim and content. Do not forget to list the dependencies required caused by those changes.

## Things to check before creating a PR

• I have inspected my topic, checked.
• If it is a core feature, executed detailed tests.

Creating PR rules

• PR must be created for an issue with approved tag. Otherwise PR will be rejected.
• Relevant issue number: The issue number related to PR must be attached to head of PR header, after prefix after prefix # must be attached in parenthesis. A header like this could be used "prefix(#issue_number): PR header" .
• A descriptive and understandable title: The PR title should clearly describe the nature and purpose of the changes. The PR title should be the first thing displayed when the PR is opened. And it should follow the semantic commit rules. For example, a title like "docs(#issueId): Add README.md" can be used.
• Related file selection: Only relevant files should be touched and no other files should be affected.
• Format and Lint Suitability : The code should be made in accordance with a certain format standard and examined according to the lint rules.
• Clean commit history: The commits where the changes are made should be clear and organized.
• Opening PR when job is completed: PR should be opened when job is completed and sent for review by other team members.

Changes

• A new feature (a change that adds a new feature, not a breaking change)
• A new refactor (a change that is not a breaking change, that improves the readability or performance of the code)
• A breaking change
• Documentation change

How were these changes tested?

Please describe the tests you did to test the changes you made. Please also specify your test configuration.

Test Configuration:

• Firmware version:
• Hardware:
• Toolchain:
• SDK:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
deprem-yardim-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Mar 3, 2023 at 9:05AM (UTC)

[yusufmeteyilmaz]

LGTM!

[yusufmeteyilmaz]

I'm sorry, I was rash.
There is a problem.
Not every request returns the same response, I mean some of them contain insufficient or irrelevant information.
I think we should use "full_text".

For example:
id:1614534
Api: https://apigo.afetharita.com/feeds/1614534
Afet harita: https://afetharita.com/en?id=1614534
Screenshot:

Rc: https://rc.afetharita.com/en?id=1614534
Screenshot:

vercel preview: https://deprem-yardim-frontend-6xmb3tl96-afet.vercel.app/en?id=1614534
Screenshot:

Response:

[absolutezero13]

@hackerone-yusuf I've changed it to full_text. Can you check?

[yusufmeteyilmaz]

Yes, it works as expected now, thanks.
But I saw the email info on one of them, I guess this kind of personal information should be filtered again.
Should I open a new issue for that?

[absolutezero13]

Yes, it works as expected now, thanks. But I saw the email info on one of them, I guess this kind of personal information should be filtered again. Should I open a new issue for that?

Hm, I am not sure about this to be honest. But I don't think there should be another issue since this is not merged.

[yusufmeteyilmaz]

@absolutezero13 Alright then, thank you again.

[usirin]

... because node v14 doesn't support replaceAll.

i am confused, why are we making a change for node 14?

[absolutezero13]

@usirin I'm not sure where but while setting up this project there was a spesific node version requirement that is around v14 or something. But if it's node v15 or above in production then it will be fine but even then there is no need to use replaceAll when there is regex.

[eraygundogmus]

I guess this is gonna only will replace the first "nan" that it find. It does not seem like a fix.

More than that, why are we replacing "nan" to "" already on frontend side? Let's fix it on backend

[absolutezero13]

Sure

[eraygundogmus]

@absolutezero13 It would be great if you could open an issue on backend, thank you. I am closing this PR, you can reopen it if you think that is wrong and anyone can reconsider! thanks for contributing