Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use MultipleTelemetry for ForwardPushTest and LateralPushTest #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use MultipleTelemetry for ForwardPushTest and LateralPushTest #11

wants to merge 2 commits into from

Conversation

bubner
Copy link

@bubner bubner commented Jan 6, 2025

Hi,

The tuning OpModes ForwardPushTest and LateralPushTest aren't using a MultipleTelemetry instance, causing ticks travelled to only display on the DS. These changes make ticks travelled show up on the dashboard too.

rbrott
rbrott reviewed Jan 23, 2025
View reviewed changes
Copy link
Member

@rbrott rbrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! I would prefer to overwrite this.telemetry instead of shadowing it with a local variable.

@bubner
Copy link
Author

bubner commented Jan 24, 2025

Sure thing. I've also adjusted the previous shadowing of telemetry in the other tuning OpModes to be consistent.

@bubner bubner requested a review from rbrott January 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbrott rbrott Awaiting requested review from rbrott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bubner @rbrott