Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git and Github Pages #15

Merged
merged 8 commits into from
Sep 8, 2023
Merged

Git and Github Pages #15

merged 8 commits into from
Sep 8, 2023

Conversation

AVERGNET
Copy link
Contributor

Git and GitHub page

@vercel
Copy link

vercel bot commented Aug 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 5:23am

angela139
angela139 requested changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the content is really good and concise! I found some spelling typos and made some suggestions.

pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
@nik-dange
Copy link
Member

Content looks good! Can we add some pictures in there? In particular, I think a picture showing the environment between your local repo, staging area, remote repo, etc. would be helpful to visualize how changes are made. Something like this
image might be helpful, I know there's also a good example on the git website itself.

khushijpatel
khushijpatel reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@khushijpatel khushijpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content, love the simplicity & detail with the steps! Left a couple suggestions

pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
nishantbalaji
nishantbalaji requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall, looks great! i left some comments where that i think things could be a bit more clear or restructured

pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
@nishantbalaji
Copy link
Member

Let's also change the PR name here to Git and Github

@AVERGNET AVERGNET changed the title Alexis/git git hub Alexis/Git and Github Aug 28, 2023
@nishantbalaji
Copy link
Member

I'll review fully in the morning but irt pr name: remove the Alexis/ from it

@nik-dange nik-dange changed the title Alexis/Git and Github Git and Github Pages Aug 28, 2023
nishantbalaji
nishantbalaji reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better! a note to add some more images so the reader can get more detailed context!

pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Outdated Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/git-github.mdx Show resolved Hide resolved
pages/hack-school/github_flow.png Outdated Show resolved Hide resolved
nishantbalaji
nishantbalaji approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! lgtm 🚢

angela139
angela139 reviewed Sep 8, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@nik-dange nik-dange merged commit 62a3912 into main Sep 8, 2023
3 checks passed
@nik-dange nik-dange deleted the alexis/Git_GitHub branch September 8, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela139 angela139 angela139 approved these changes

@nishantbalaji nishantbalaji nishantbalaji approved these changes

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

@khushijpatel khushijpatel Awaiting requested review from khushijpatel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AVERGNET @nik-dange @nishantbalaji @angela139 @khushijpatel @avVergnet