Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Page #17

Merged
merged 6 commits into from
Sep 15, 2023
Merged

HTML Page #17

merged 6 commits into from
Sep 15, 2023

Conversation

charvishukla
Copy link
Contributor

This one should have everything (or i'm just crazy). Again, if you have any inputs on topics to add, remove or reorder, let me know.

@vercel
Copy link

vercel bot commented Aug 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 10:37pm

nik-dange
nik-dange requested changes Aug 27, 2023
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! This chapter looks good to me, I made a few small suggestions for typos and nits. Let me know if you have any questions.

pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Show resolved Hide resolved
pages/hack-school/_meta.json Outdated Show resolved Hide resolved
nishantbalaji
nishantbalaji requested changes Aug 28, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! i love the explanations and the writing, its very descriptive :DD my main nit is that you could have some more pictures here and there, maybe this is a great place to utilize the library i linked in discord.

yarn.lock Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
pages/hack-school/_meta.json Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
@nishantbalaji
Copy link
Member

Let's change the PR name here to HTML or HTML and CSS if you do both in this PR

@nik-dange nik-dange changed the title Charvi/html HTML Page Aug 28, 2023
angela139
angela139 reviewed Aug 28, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content was really good! I left some comments about typos and places you can try to add more images/visualization. For the code blocks, I also saw that you can't copy them but you can copy them for the CSS/Javascript pages that Alexis worked on. You should probably make them all copy-able.

pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Show resolved Hide resolved
pages/hack-school/html.mdx Outdated Show resolved Hide resolved
pages/hack-school/html.mdx Show resolved Hide resolved
nik-dange
nik-dange approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nishantbalaji
nishantbalaji approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@charvishukla charvishukla merged commit bb70031 into main Sep 15, 2023
3 checks passed
@charvishukla charvishukla deleted the charvi/html branch September 15, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela139 angela139 angela139 left review comments

@nik-dange nik-dange nik-dange approved these changes

@nishantbalaji nishantbalaji nishantbalaji approved these changes

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

@AVERGNET AVERGNET Awaiting requested review from AVERGNET AVERGNET is a code owner automatically assigned from acmucsd/acm-hack

Assignees

@charvishukla charvishukla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@charvishukla @nishantbalaji @nik-dange @angela139