Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homepage Team Section #26

Merged
merged 29 commits into from
Sep 29, 2023
Merged

Homepage Team Section #26

merged 29 commits into from
Sep 29, 2023

Conversation

AVERGNET
Copy link
Contributor

No description provided.

angela139 and others added 21 commits September 4, 2023 21:31
@angela139
Set up structure for homepage
4b87bd7
@angela139
Merge branch 'main' into angela/homepage-setup
ff51517
@angela139
Added landing card and restructured
4a76537
@angela139
Added starter code for components
4f0e9c2
@angela139
Fixed the scroll for arrow icon + updated components template code
15a92d7
@angela139
Fixing yarn stuff
abdd176
@avVergnet
Team cards added to homepage
abaf05f
@angela139
Made page responsive and minor fixes
bd8b471
@angela139
Merge branch 'main' into angela/homepage-setup
b5ab0a9
@angela139
Merge branch 'angela/homepage-setup' of https://github.com/acmucsd/ha…
f312447 
…ck-website into angela/homepage-setup
@angela139
Fixed errors for Alexis changes
ac27238
@angela139
Dark mode isn't set up yet
f111248
@avVergnet
Fixed index key error during vercel build
1c1a97f
@AVERGNET @avVergnet
Fixed index key error during vercel build (#25)
6284b23 
Co-authored-by: avVergnet <[email protected]>
@angela139
Minor cleanup
824e2d7
@angela139
Merge branch 'angela/homepage-setup' of https://github.com/acmucsd/ha…
5729456 
…ck-website into angela/homepage-setup
@angela139
Improved flexbox
cffd40f
@angela139
Accidentally deleted the wrong code
33d6f11
@angela139
Title doesn't move with typewriter
17b6d2d
@avVergnet
Fixed rows and added icons and changed outline color
27e1cac
@avVergnet
fixing yarn and vercel errors
445df5c
@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 11:19pm

nishantbalaji
nishantbalaji requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@nishantbalaji nishantbalaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's hold off on merge until @angela139 's PR #23 is in. In the meantime, could you fix Nikhils photo being smaller than the rest:
image

@nik-dange
Copy link
Member

nik-dange commented Sep 13, 2023 •
edited
Loading

Also in light mode, I think the box shadow is pretty apparent. Should we remove it and possibly add padding to the left side of me and right side of you? Good work though, it looks great!
Screenshot 2023-09-13 at 8 51 27 AM

@nik-dange nik-dange added the hold off on merge Do not merge until approval is given; waiting on another PR to be merged first. label Sep 14, 2023
Base automatically changed from angela/homepage-setup to main September 15, 2023 08:50
@angela139 angela139 linked an issue Sep 15, 2023 that may be closed by this pull request
Hack Website Frontpage: Team Section #21
Closed
angela139
angela139 requested changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think it's pretty solid! I think main thing is the layout for mobile/tablet devices has to be fixed and remember to pull in the new changes from the main.

src/components/team-card/style.module.css Outdated Show resolved Hide resolved
src/components/team-card/index.tsx Outdated Show resolved Hide resolved
src/components/team-card/index.tsx Outdated Show resolved Hide resolved
src/components/team-card/index.tsx Outdated Show resolved Hide resolved
@nik-dange nik-dange removed the hold off on merge Do not merge until approval is given; waiting on another PR to be merged first. label Sep 23, 2023
@AVERGNET AVERGNET changed the title Homepage team section added icons and fixing render issues Homepage Team Section Sep 25, 2023
angela139
angela139 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nik-dange nik-dange merged commit b3fba18 into main Sep 29, 2023
4 checks passed
@nik-dange nik-dange deleted the alexis/homepage-team-section branch September 29, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishantbalaji nishantbalaji nishantbalaji approved these changes

@angela139 angela139 angela139 approved these changes

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

@charvishukla charvishukla Awaiting requested review from charvishukla charvishukla is a code owner automatically assigned from acmucsd/acm-hack

Assignees

@AVERGNET AVERGNET

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hack Website Frontpage: Team Section
5 participants
@AVERGNET @nik-dange @nishantbalaji @angela139 @avVergnet