Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated hero animation and style #56

Merged
merged 8 commits into from
Sep 12, 2024
Merged

Updated hero animation and style #56

merged 8 commits into from
Sep 12, 2024

Conversation

angela139
Copy link
Contributor

  • Centered hero and updated svg images
  • Replaced text animation with text-reveal on ACM Hack instead of caption
  • Added framer-motion library for animation

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 8:05am

@angela139 angela139 linked an issue Jan 3, 2024 that may be closed by this pull request
Changes to hero section positioning and animation #44
Closed
3 tasks
@angela139
Copy link
Contributor Author

  • Updated hero for desktop view to have same layout as tablet
  • Added new animation with build, break, innovate

nathanwang0114
nathanwang0114 approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@nathanwang0114 nathanwang0114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I like the changes with the new build, break, and innovate. The animations for them are clean and simple without overdoing it and keeping the desktop view consistent with the tablet view is nice.

@nathanwang0114 nathanwang0114 merged commit dbc2d12 into main Sep 12, 2024
4 checks passed
@nathanwang0114 nathanwang0114 deleted the fix/hero-improvements branch September 12, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanwang0114 nathanwang0114 nathanwang0114 approved these changes

@nishantbalaji nishantbalaji Awaiting requested review from nishantbalaji

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

@khushijpatel khushijpatel Awaiting requested review from khushijpatel khushijpatel is a code owner automatically assigned from acmucsd/acm-hack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to hero section positioning and animation
2 participants
@angela139 @nathanwang0114