Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Images To CSS Page #78

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Conversation

shreyaNagunuri
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 6:06am

Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think the new images will really help people visual the CSS properties more! I added some comments for areas of improvement

pages/hack-school/css.mdx Show resolved Hide resolved
pages/hack-school/css.mdx Show resolved Hide resolved
pages/hack-school/css.mdx Show resolved Hide resolved
pages/hack-school/CSS_images/floating_image.png Outdated Show resolved Hide resolved
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just remember to remove the .DS_Store cache files before you merge it in

pages/hack-school/.DS_Store Outdated Show resolved Hide resolved
pages/hack-school/CSS_images/.DS_Store Outdated Show resolved Hide resolved
@shreyaNagunuri shreyaNagunuri merged commit 7f8a292 into main Sep 10, 2024
4 checks passed
@shreyaNagunuri shreyaNagunuri deleted the add-more-visuals-css-textbook branch September 10, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants