Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework js hack school #79

Merged
merged 8 commits into from
Sep 22, 2024
Merged

Rework js hack school #79

merged 8 commits into from
Sep 22, 2024

Conversation

kevinlu021
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2024 0:45am

angela139
angela139 requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I like the new changes for the JS page, especially fixing the past spelling/consistency mistakes! I left some comments on some more spelling typos and areas where you can add more to the content

pages/hack-school/js.mdx Show resolved Hide resolved
pages/hack-school/toggle_component.jsx Outdated Show resolved Hide resolved
pages/hack-school/toggle_component.jsx Outdated Show resolved Hide resolved
pages/hack-school/toggle_component.jsx Outdated Show resolved Hide resolved
pages/hack-school/js.mdx Show resolved Hide resolved
pages/hack-school/js.mdx Show resolved Hide resolved
@angela139 angela139 removed the request for review from nishantbalaji September 12, 2024 21:01
angela139
angela139 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinlu021 kevinlu021 merged commit 41f2518 into main Sep 22, 2024
4 checks passed
@kevinlu021 kevinlu021 deleted the rework-js-hack-school branch September 22, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela139 angela139 angela139 approved these changes

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

@nik-dange nik-dange Awaiting requested review from nik-dange nik-dange is a code owner automatically assigned from acmucsd/acm-hack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlu021 @angela139