Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added 3 exercises to js school #80

Merged
merged 10 commits into from
Sep 22, 2024
Merged

added 3 exercises to js school #80

merged 10 commits into from
Sep 22, 2024

Conversation

kevinlu021
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 6:20am

angela139
angela139 requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exercises look good to me! Although I said to only add 3 exercises, it would be good to have a exercise for the async/await section so people can get more help with that

pages/hack-school/toggle_component.jsx Outdated Show resolved Hide resolved
angela139
angela139 reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New activity looks good to me! My only nit is the button color should be an orange hue, so it's visible for both light and dark mode
Screenshot 2024-09-19 at 10 43 00 PM
Screenshot 2024-09-19 at 10 43 10 PM

angela139
angela139 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@angela139 angela139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kevinlu021 kevinlu021 merged commit c08ca49 into main Sep 22, 2024
4 checks passed
@kevinlu021 kevinlu021 deleted the add-3-js-exercises branch September 22, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela139 angela139 angela139 approved these changes

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinlu021 @angela139