Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/upload board photo #9

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Feature/upload board photo #9

wants to merge 13 commits into from

Conversation

alexzhang1618
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
klefki ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:21am
testing-klefki ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 3:21am

@newracket newracket marked this pull request as ready for review December 3, 2024 03:47
@newracket newracket self-requested a review December 3, 2024 03:48
alexzhang1618
alexzhang1618 commented Dec 3, 2024
View reviewed changes
Copy link
Contributor Author

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, curious how we have aws permissioning setup but I assume it works since we can view portal photos

app/api/v1/board/uploadPhoto/route.ts Outdated Show resolved Hide resolved
app/api/v1/board/uploadPhoto/route.ts Outdated Show resolved Hide resolved
src/util/board.ts Show resolved Hide resolved
src/util/index.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newracket newracket newracket approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexzhang1618 @newracket @maxwn04