Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Server Error Page #129

Merged
merged 4 commits into from
Jan 20, 2024
Merged

Internal Server Error Page #129

merged 4 commits into from
Jan 20, 2024

Conversation

farisashai
Copy link
Member

@farisashai farisashai commented Jan 20, 2024

custom 500 page makes it easier to recover to a stable client state by logging out (clearing all cookies)

can design something nicer later on

this page will be hit when serversideprops hits an exception such as

  • corrupted cookies
  • existing but invalid auth token
  • api goes down
  • invalid api response

the first 2 cases are easily recoverable by logging out and the last 2 make the portal unusable anyways so they can't be solved by the user

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Copy link

vercel bot commented Jan 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2024 4:43pm

@farisashai farisashai changed the title Create 500.tsx Internal Server Error Page Jan 20, 2024
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is there a screenshot of the page?

@farisashai
Copy link
Member Author

just go to /500

@alexzhang1618
Copy link
Contributor

Screenshot 2024-01-20 at 8 37 47 AM

@alexzhang1618
Copy link
Contributor

Can we make the link blue so it's clear that it's clickable?

@farisashai farisashai merged commit cfcc18b into main Jan 20, 2024
5 checks passed
@farisashai farisashai deleted the faris/500_page branch January 20, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants