Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal that gets displayed on successful checkin #152

Merged
merged 4 commits into from
Feb 20, 2024

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Feb 20, 2024

Info

Closes #144 .

Changes

  • Open a modal on successful checkin
  • Other bug fixes:
    • Display error when unsuccessfully deleting an event in /admin/event
    • Fixing a styling bug with bottomSheet modals (all mobile modals would have border radius chopped instead of just bottomSheet ones)
    • Align text with switches on /edit/profile
    • Disable caching on home page

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2024-02-19 at 7 29 15 PM
Screenshot 2024-02-19 at 7 29 32 PM
Screenshot 2024-02-19 at 7 30 06 PM

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 10:55pm

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicks and a bug but overall ltgm

public/assets/graphics/portal/treasure.svg Outdated Show resolved Hide resolved
src/components/events/CheckInModal/index.tsx Outdated Show resolved Hide resolved
src/components/events/CheckInModal/index.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
@alexzhang1618
Copy link
Contributor Author

Edited modal:
Screenshot 2024-02-20 at 2 36 53 PM
Screenshot 2024-02-20 at 2 37 20 PM

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgbtm

src/components/events/CheckInModal/index.tsx Show resolved Hide resolved
@alexzhang1618 alexzhang1618 merged commit 18be91c into main Feb 20, 2024
5 checks passed
@alexzhang1618 alexzhang1618 deleted the checkin-modal branch February 20, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center text with toggle
2 participants