Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sean/collection images #161

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Sean/collection images #161

merged 5 commits into from
Feb 27, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Feb 27, 2024

Info

Closes #134.

show and edit collection images

question: what aspect ratio should collection photos be? currently they're 1:1, but that's not the case in the design

Changes

  • updated apiRequests/apiResponses
  • added the draggable photos thingy from edit item page to collection page
  • collection cards now use collection photos; they still default to item photos after that
  • collection page has them photos too (desktop only)

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image

image

image

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 3:45am

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm lgtm lgtm lgtm lgtm

@SheepTester SheepTester merged commit d7b43e2 into main Feb 27, 2024
5 checks passed
@SheepTester SheepTester deleted the sean/collection-images branch February 27, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collections Page Images
2 participants