Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Live tag to events, add placeholder for empty event carousels #184

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Mar 28, 2024

Changes

  • Closes carousel cards too big #181
    • Added a max-width to event cards so they fit inside mobile screens and have space for the next card
    • Still trying to figure out how to make the bottom of the cards stretch out if other cards in the carousel have started wrapping
      • switching eventcard to flex didn't work, block has weird image alignment that I couldn't figure out
  • Adding a placeholder for event carousels with no events
  • Adding a Live tag for events that are happening right now

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2024-03-27 at 9 12 24 PM Screenshot 2024-03-27 at 9 22 41 PM Screenshot 2024-03-27 at 10 16 24 PM

@alexzhang1618 alexzhang1618 marked this pull request as ready for review March 28, 2024 04:25
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 5:09am

@SheepTester
Copy link
Member

Since the badges can wrap now, can it get cut off on the pickup page

@alexzhang1618
Copy link
Contributor Author

Since the badges can wrap now, can it get cut off on the pickup page

No since the change is only for event cards inside the EventCarousel

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

since you're letting badges wrap now, would it make sense to allow the event names/locations to wrap too?

image

Still trying to figure out how to make the bottom of the cards stretch out if other cards in the carousel have started wrapping

  • switching eventcard to flex didn't work, block has weird image alignment that I couldn't figure out
  1. align-items: stretch on .slider
  2. remove height: fit-content; from .container for the event card to allow it to stretch
  3. the image is aligned weirdly because <button> elements vertically center their content by default. you could do display: flex; flex-direction: column; on the event card, then add width: 100%; to .info so the text doesn't overflow

@alexzhang1618
Copy link
Contributor Author

since you're letting badges wrap now, would it make sense to allow the event names/locations to wrap too?

hmm maybe let's play around with this and figure out if we want it, for now I'll leave it out

@alexzhang1618 alexzhang1618 merged commit 7d9eaa4 into main Mar 29, 2024
5 checks passed
@alexzhang1618 alexzhang1618 deleted the dashboard-tweaks branch March 29, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

carousel cards too big
2 participants