-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Live tag to events, add placeholder for empty event carousels #184
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Since the badges can wrap now, can it get cut off on the pickup page |
No since the change is only for event cards inside the EventCarousel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
since you're letting badges wrap now, would it make sense to allow the event names/locations to wrap too?
Still trying to figure out how to make the bottom of the cards stretch out if other cards in the carousel have started wrapping
- switching eventcard to flex didn't work, block has weird image alignment that I couldn't figure out
align-items: stretch
on.slider
- remove
height: fit-content;
from.container
for the event card to allow it to stretch - the image is aligned weirdly because
<button>
elements vertically center their content by default. you could dodisplay: flex; flex-direction: column;
on the event card, then addwidth: 100%;
to.info
so the text doesn't overflow
hmm maybe let's play around with this and figure out if we want it, for now I'll leave it out |
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*
and commented hard to understand areasanywhere else.
Screenshots