Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Event Page Query Params + More #202

Closed
wants to merge 10 commits into from
Closed

Event Page Query Params + More #202

wants to merge 10 commits into from

Conversation

farisashai
Copy link
Member

Info

Closes #200
Closes #187
Closes #185

Changes

  • [Fill in here]

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

@vercel Vercel
Copy link

vercel bot commented Mar 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 30, 2024 11:27pm

@farisashai farisashai changed the title Faris/fun fixes Event Page Query Params + More Mar 30, 2024
@farisashai farisashai mentioned this pull request Mar 30, 2024
Merged
14 tasks
SheepTester
SheepTester approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just some nitpicks

src/components/events/EventCarousel/index.tsx Outdated Show resolved Hide resolved
src/pages/events.tsx Outdated Show resolved Hide resolved
src/pages/index.tsx Outdated Show resolved Hide resolved
src/components/profile/UserProgress/index.tsx Outdated Show resolved Hide resolved
@farisashai
Copy link
Member Author

Fixing in #199

@farisashai farisashai closed this Mar 31, 2024
@alexzhang1618 alexzhang1618 mentioned this pull request Mar 31, 2024
Merged
@farisashai farisashai deleted the faris/fun-fixes branch March 31, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SheepTester SheepTester SheepTester approved these changes

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

@alexzhang1618 alexzhang1618 Awaiting requested review from alexzhang1618 alexzhang1618 is a code owner

Assignees

@farisashai farisashai

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
2 participants
@farisashai @SheepTester