Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates to onboarding #267

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Minor updates to onboarding #267

merged 12 commits into from
Nov 25, 2024

Conversation

SheepTester
Copy link
Member

@SheepTester SheepTester commented Oct 22, 2024 •
edited
Loading

Info

adjustments to onboarding

Changes

  • replaced temporary images on first page
  • made leaderboard look better on mobile
  • whether onboarding was viewed is now stored on backend

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image

2024-11-03.20-18-48.mp4

image

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:12am
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:12am

@SheepTester SheepTester marked this pull request as ready for review November 4, 2024 04:09
newracket
newracket approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@newracket newracket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really know how animations work but it looks good to me

alexzhang1618
alexzhang1618 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, some nits:

Let's try and rename the asset files to be as terse as possible. I think it's implicit that this is ACM, and we can probably shorten each file name to be something like
FA23_Allocation, FA24_BitByteInfo_1, etc.

src/pages/index.tsx Outdated Show resolved Hide resolved
src/components/onboarding/Intro/index.tsx Outdated Show resolved Hide resolved
src/components/onboarding/Intro/index.tsx Outdated Show resolved Hide resolved
src/components/onboarding/Intro/index.tsx Outdated Show resolved Hide resolved
src/components/onboarding/Intro/index.tsx Outdated Show resolved Hide resolved
@SheepTester SheepTester merged commit b35f962 into main Nov 25, 2024
8 checks passed
@SheepTester SheepTester deleted the sean/onboarding-fixes branch November 25, 2024 07:13
Chaitya2108 pushed a commit that referenced this pull request Jan 9, 2025
@SheepTester @Chaitya2108
Minor updates to onboarding (#267)
03e520f 
* add potential photos for onboarding first slide from justin

* increase leaderboard row height on mobile??

* fmt

* fmt

* use css var for positioning

* Arrange onboarding photos

* 3d effect for mouse users

* mobile collage layout

* improve leaderboard on mobile

* use backend support for whether onboarding seen

* refactor intro images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzhang1618 alexzhang1618 alexzhang1618 approved these changes

@newracket newracket newracket approved these changes

@farisashai farisashai Awaiting requested review from farisashai farisashai is a code owner

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

Assignees

@SheepTester SheepTester

Labels
PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SheepTester @newracket @alexzhang1618