Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Description
Implements a reusable
Typography
component that applies styles h1-h6 from the design system, as well as design system v2. This makes it super convenient to style all text in designs using this design system, including the store redesigns 👀. General syntax is<Typography variant="h1/bold">A Heading</Typography>
. Also supports passing acomponent
prop to specify the semantic component.This component can potentially be refactored to a standalone ACM component library.
Below is some example usage. The source code for the image below is also available.
Changes
Typography
component atsrc/components/common/Typography.tsx
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
Please include a screenshot of your Cypress testing suite passing successfully.
If you made any visual changes to the website, please include relevant screenshots below.