Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Typography component #88

Merged
merged 5 commits into from
Dec 18, 2023
Merged

Conversation

raymosun
Copy link
Contributor

@raymosun raymosun commented Nov 6, 2023

Info

Description

Implements a reusable Typography component that applies styles h1-h6 from the design system, as well as design system v2. This makes it super convenient to style all text in designs using this design system, including the store redesigns 👀. General syntax is <Typography variant="h1/bold">A Heading</Typography> . Also supports passing a component prop to specify the semantic component.

This component can potentially be refactored to a standalone ACM component library.

Below is some example usage. The source code for the image below is also available.

image
image

Changes

  • Implements Typography component at src/components/common/Typography.tsx

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Cypress testing suite passing successfully.

If you made any visual changes to the website, please include relevant screenshots below.

Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2023 8:14am

Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent work bobblemond 👍

@raymosun raymosun merged commit a7094ff into main Dec 18, 2023
2 of 3 checks passed
@raymosun raymosun deleted the raymond/typography-component branch December 18, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants