Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Deprecated CI Docker Images #420

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

nik-dange
Copy link
Member

Info

Partially closes #289

Description

The Docker images that we use on CircleCI are deprecated, and we should switch to their next-gen images. More info here: https://circleci.com/docs/next-gen-migration-guide/, but this change should be more reliable/maintained/ideally speed up deployment times.

Changes

  • Switched Node images from circleci to cimg

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@nik-dange
Copy link
Member Author

nik-dange commented Mar 26, 2024

I was able to find a matching next-gen image for our Node v14.17.6 ones from here (https://circleci.com/developer/images/image/cimg/node), but I was unable to find a 1:1 match for our Postgres image (which uses v11.5), see https://circleci.com/developer/images/image/cimg/postgres. Thoughts on moving forward from this? Using the closest minor version vs. overall upgrading our Postgres version? Would need to look into going about the latter but it might not be a bad idea

Copy link
Collaborator

@shravanhariharan2 shravanhariharan2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth looking into upgrading both our Node and Postgres versions at some point, though I don't think it needs to be scoped into this PR. The current Node LTS is v20.12.X, so we're fairly far behind and are at some level of risk to vulnerabilities that could be patched in more recent updates - and the same goes for Postgres.

If the deprecated images is a blocker (i.e. CCI is going to remove the images entirely from their old-gen repository), then it's worth bumping Postgres to a supported minor version on 11.X. Then, we can later look into upgrading the major version, using the testing instance and our unit tests to heavily validate that nothing's broken.

Approving this PR to unblock, but I'd make sure this behaves as intended when deploying onto the testing instance first before merging to master.

@sumeet-bansal sumeet-bansal removed their request for review September 13, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants