-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Deprecated CI Docker Images #420
base: master
Are you sure you want to change the base?
Conversation
…into feature/update-ci-docker-images merging from master
Thanks for contributing! |
I was able to find a matching next-gen image for our Node v14.17.6 ones from here (https://circleci.com/developer/images/image/cimg/node), but I was unable to find a 1:1 match for our Postgres image (which uses v11.5), see https://circleci.com/developer/images/image/cimg/postgres. Thoughts on moving forward from this? Using the closest minor version vs. overall upgrading our Postgres version? Would need to look into going about the latter but it might not be a bad idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth looking into upgrading both our Node and Postgres versions at some point, though I don't think it needs to be scoped into this PR. The current Node LTS is v20.12.X, so we're fairly far behind and are at some level of risk to vulnerabilities that could be patched in more recent updates - and the same goes for Postgres.
If the deprecated images is a blocker (i.e. CCI is going to remove the images entirely from their old-gen repository), then it's worth bumping Postgres to a supported minor version on 11.X. Then, we can later look into upgrading the major version, using the testing instance and our unit tests to heavily validate that nothing's broken.
Approving this PR to unblock, but I'd make sure this behaves as intended when deploying onto the testing instance first before merging to master.
Info
Partially closes #289
Description
The Docker images that we use on CircleCI are deprecated, and we should switch to their next-gen images. More info here: https://circleci.com/docs/next-gen-migration-guide/, but this change should be more reliable/maintained/ideally speed up deployment times.
Changes
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json
!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.json
file.Screenshots
Please include a screenshot of your Postman testing passing successfully.