Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event route refactor #431

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

yimmyj
Copy link
Contributor

@yimmyj yimmyj commented Apr 8, 2024

Info

Closes 429.

Description

implemented new routes:

feedback/event/:uuid: retrieves the user's feedback on a given event

event/:uuid/feedback: retrieves all feedback for a given event. [admin only]

removed current structure in feedbackcontroller that expects query params from frontend

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Get all feedback for event:

Screenshot 2024-04-08 at 12 32 56 AM

Get all feedback for event as a standard user (error):

Screenshot 2024-04-08 at 12 48 39 AM

Get own feedback for event:

Screenshot 2024-04-08 at 12 48 13 AM

Copy link

github-actions bot commented Apr 8, 2024

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@nik-dange
Copy link
Member

Marking as revisit for now. Waiting on design team to provide some updated designs for Feedback so we can restructure and rescope it on the backend

@sumeet-bansal sumeet-bansal removed their request for review September 13, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants