Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node Version to 20.12.2 #435

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Update Node Version to 20.12.2 #435

wants to merge 17 commits into from

Conversation

maxwn04
Copy link
Contributor

@maxwn04 maxwn04 commented Apr 13, 2024

Info

Closes 434. (If there is no issue for this pull request yet, please create one or
delete this line if the pull request is for a very minor tweak).

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

Update Node Version

Changes

  • Update node to version 20.12.2

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@maxwn04 maxwn04 changed the title Patch/update node Update Node Version to 20.12.2 Apr 13, 2024
@maxwn04 maxwn04 marked this pull request as draft April 13, 2024 20:23
@maxwn04 maxwn04 marked this pull request as ready for review April 24, 2024 23:23
@maxwn04 maxwn04 force-pushed the patch/update-node branch from 2367817 to d6ba260 Compare April 29, 2024 08:06
@maxwn04
Copy link
Contributor Author

maxwn04 commented Apr 29, 2024

Imports that break stuff
class-validator: 0.12.2 -> 0.14.2 - breaks user handle tests
image

Warnings that are still present:
image
image

  • class-validator breaks user.handle.test.ts not sure why will investigate a bit more

  • Warning for unused rdfc import, but removing the import breaks things

  • AWS should be managed in another pr

  • Multer still shows that warning when running yarn upgrade but not present when running yarn install even after switching to 1.4.4-lts.1. EDIT: fixed usign 1.4.5-lts.1

  • Still somewhat inconsistent with userSocialMedia tests taking too long

@sumeet-bansal sumeet-bansal removed their request for review September 13, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant