Moving most public types to API layer #452
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #326
Description
What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.
Changes were made to almost all the controller classes in the API layer, as well as their corresponding service classes in the service layer. The mapping of private to public types was moved from the service layer to the API layer.
Changes
API Layer
AdminController.ts
AttendanceController.ts
EventController.ts
FeedbackController.ts
LeaderboardController.ts
MerchStoreController.ts
UserController.ts
Service Layer
AttendanceService.ts
EventService.ts
FeedbackService.ts
MerchStoreService.ts
UserAccountService.ts
Type of Change
expected)
workflows, linting, etc.)
If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in
package.json
!Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
package.json
file.Screenshots
Please include a screenshot of your Postman testing passing successfully.