Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added food field to events table #456

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Conversation

newracket
Copy link
Contributor

@newracket newracket commented Oct 22, 2024

Info

Closes #455

Description

I added a migration to add a new "food" column to the events table. I also added the food field (not requied) to every events object, and the API endpoints.

Changes

  • added migration to add new food column to events table
  • added food field to event object and /event API endpoints

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Create Event - Food field present:
image

Create Event - No food field:
image

Get all Events:
image

Copy link

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@newracket newracket changed the title zadded food field to events table added food field to events table Oct 22, 2024
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nits, but looks good to me. Make sure to change the name everywhere it's defined. Also, update our API docs on Postman to include this change

models/EventModel.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
migrations/0046-add-food-column.ts Outdated Show resolved Hide resolved
Copy link
Member

@nik-dange nik-dange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀 congrats on your first portal contribution

Copy link
Contributor

@maxwn04 maxwn04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@newracket newracket merged commit ff05d6b into master Oct 25, 2024
5 checks passed
@newracket newracket deleted the add-food-to-events-table branch October 25, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add food field to events table/endpoint
3 participants