WIP: Add a generic hmac client that other apis can impliment. #61
+553
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mglaman
suggested changes
Oct 19, 2022
|
Unsubscribe
On Wed, Oct 19, 2022 at 2:41 PM Matt Glaman ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Guzzle's Client class is final in Guzzle 8. Composing clients around
Guzzle is better than extending it.
—
Reply to this email directly, view it on GitHub
<#61 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEDUD6IJJSKX4ZMS57CCNTWEA6GNANCNFSM53IJRJBQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Laura Gregory
***@***.***
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of our products are doing the same thing in regards to an hmac client. Instead of re-inventing the wheel over and over, have hmac clients extend this base hmac client, overriding some key methods that are specific to the api implimentation.