Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unique alias to custom objects query #321

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

galvani
Copy link
Contributor

@galvani galvani commented Jul 28, 2023

Q A
Bug fix? (use the a.b branch) [X]

Description:

in case that filter contains two possible values for one filter only one value was used the alias for the union joins was not unique. this fixes it.

Steps to test this PR:

  1. Create a report with custom field in dev environment so you can see the SQL
  2. filter by same custom fields with two diffetent values like: text = aaa and text = bbb (multiple relations, so it makes sense)
  3. check the SQL outputted in the report view.

@driskell
Copy link

Might be fixed by #322 in a more complete way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants