-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zarr v3 #116
Zarr v3 #116
Conversation
aliddell
commented
Nov 22, 2023
•
edited
Loading
edited
- Update Zarr driver to add Zarr V3 support.
- Add tests for Zarr V3.
- Small fixes in README.
- Minor version bump.
Revert minor version bump.
This reverts commit b3c90dd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I just have a question about version numbers.
@@ -1,7 +1,7 @@ | |||
[package] | |||
name = "acquire-imaging" | |||
authors = ["Nathan Clack <[email protected]>"] | |||
version = "0.1.4" | |||
version = "0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I understand the minor bump here as representing a pre-v1 breaking change to the public API (i.e. because we removed ChunkingProperties
)?
Should there have been an equivalent minor version bump for acquire-core-libs for the equivalent change there? If so, I don't think we have to do that now, but wanted to check to see if I understand things correctly.