Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zarr v3 #116

Merged
merged 11 commits into from
Nov 22, 2023
Merged

Zarr v3 #116

merged 11 commits into from
Nov 22, 2023

Conversation

aliddell
Copy link
Member

@aliddell aliddell commented Nov 22, 2023

  • Update Zarr driver to add Zarr V3 support.
  • Add tests for Zarr V3.
  • Small fixes in README.
  • Minor version bump.

@aliddell aliddell marked this pull request as ready for review November 22, 2023 15:55
Copy link
Contributor

@andy-sweet andy-sweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I just have a question about version numbers.

@@ -1,7 +1,7 @@
[package]
name = "acquire-imaging"
authors = ["Nathan Clack <[email protected]>"]
version = "0.1.4"
version = "0.2.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I understand the minor bump here as representing a pre-v1 breaking change to the public API (i.e. because we removed ChunkingProperties)?

Should there have been an equivalent minor version bump for acquire-core-libs for the equivalent change there? If so, I don't think we have to do that now, but wanted to check to see if I understand things correctly.

@aliddell aliddell merged commit cf31027 into acquire-project:main Nov 22, 2023
11 of 20 checks passed
@aliddell aliddell deleted the zarrv3 branch November 22, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants