Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drmorr/custom flush times #7

Merged
merged 2 commits into from
Jul 27, 2024
Merged

Drmorr/custom flush times #7

merged 2 commits into from
Jul 27, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Jul 24, 2024

Add a --flush-interval flag to allow you to set custom flush times, instead of hard-coding to 1 hour

@drmorr0 drmorr0 force-pushed the drmorr/custom-flush-times branch from 19164e7 to c9933d5 Compare July 25, 2024 01:49
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 21 lines in your changes missing coverage. Please review.

Project coverage is 43.65%. Comparing base (3e4ad72) to head (c9933d5).
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/parquet/writer.go 65.85% 11 Missing and 3 partials ⚠️
cmd/root.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   40.18%   43.65%   +3.47%     
==========================================
  Files           7        7              
  Lines         331      339       +8     
==========================================
+ Hits          133      148      +15     
+ Misses        189      180       -9     
- Partials        9       11       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 merged commit 740ced2 into master Jul 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant