Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: misaligned error display in skctl xray #165

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Nov 30, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

We double-counted columns in the error view when determining how much to truncate for the item name display in skctl xray, which led names getting truncated when they shouldn't have been.

Testing done

  • manual testing
  • it'd be sorta nice to have a snapshot test for this since the other snapshot tests didn't catch it, but it's kindof a pain to do so I didn't bother.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.81%. Comparing base (7b7fb4a) to head (5599980).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
- Coverage   72.84%   72.81%   -0.03%     
==========================================
  Files          55       55              
  Lines        2975     2972       -3     
==========================================
- Hits         2167     2164       -3     
  Misses        808      808              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 merged commit 71a5eee into master Nov 30, 2024
8 checks passed
@drmorr0 drmorr0 deleted the drmorr/fix-xray-display branch November 30, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant