Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: InsertAt patch location + secondary patch for service_account_missing #170

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

drmorr0
Copy link
Contributor

@drmorr0 drmorr0 commented Dec 19, 2024

  • I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.

Description

  • Adds the InsertAt patch location for annotations
  • Updates the service_account_missing check to use this patch location as a secondary patch alternative

Testing done

  • make test (new tests added for InsertAt)

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 91.34615% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.18%. Comparing base (6fbf91f) to head (2266f08).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sk-cli/src/validation/annotated_trace.rs 91.07% 5 Missing ⚠️
...li/src/validation/rules/service_account_missing.rs 91.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
+ Coverage   72.91%   73.18%   +0.27%     
==========================================
  Files          56       56              
  Lines        3020     3107      +87     
==========================================
+ Hits         2202     2274      +72     
- Misses        818      833      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drmorr0 drmorr0 force-pushed the push-psrmtqxskstn branch 2 times, most recently from 737abdc to ef20be4 Compare December 20, 2024 17:48
@drmorr0 drmorr0 merged commit e658de8 into master Dec 21, 2024
8 checks passed
@drmorr0 drmorr0 deleted the push-psrmtqxskstn branch December 21, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant