Skip to content

Commit

Permalink
Merge pull request #100 from acsone/rm-flake8-pylint
Browse files Browse the repository at this point in the history
Remove flake8 and pylint command
  • Loading branch information
sbidoul authored Feb 21, 2023
2 parents e8f9309 + aa2cd82 commit 67357ba
Show file tree
Hide file tree
Showing 11 changed files with 0 additions and 533 deletions.
49 changes: 0 additions & 49 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -146,55 +146,6 @@ the `build` stage in the project template.**
Perform ``acsoo tag``, ``acsoo tag_requirements`` and
``acsoo wheel`` in one command.

acsoo flake8
------------

**This command is deprecated, use a .flake8 file in your project,
in combination with pre-commit. See the project template for a reasonable default.**

Run `flake8 <https://pypi.python.org/pypi/flake8>`_ with sensible default for Odoo code.

It is possible to pass additional options to the ``flake8`` command, eg:

.. code:: shell
acsoo flake8 -- --ignore E24,W504
acsoo pylint
------------

**This command is deprecated, use a .pylintrc file in your project,
in combination with pre-commit. See the project template for a reasonable default.**

Run `pylint <https://pypi.python.org/pypi/pylint>`_ on detected Odoo addons in odoo/addons,
odoo_addons or the current directory.
It automatically uses the `pylint-odoo <https://pypi.python.org/pypi/pylint-odoo>`_ plugin and
runs with a reasonable configuration, including an opinionated set of disabled message.

It is possible to pass additional options to the ``pylint`` command, eg:

.. code:: shell
acsoo pylint -- --disable missing-final-newline
This command returns an non-zero exit code if any message is reported.
It is however possibly to display messages while reporting success, eg:

.. code:: shell
acsoo pylint --expected api-one-deprecated:2,line-too-long
The above command succeeds despite having exactly 2 ``api-one-deprecated`` or
any number of ``line-too-long`` messages being reported.

It is also possible to force failure on messages that are ``expected`` in the
default configuration, eg to fail on ``fixme`` errors, just expect 0 ``fixme``
messages, like this:

.. code:: shell
acsoo pylint --expected fixme:0
acsoo.cfg
~~~~~~~~~

Expand Down
2 changes: 0 additions & 2 deletions acsoo/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@
# commands
from . import addons
from . import checklog
from . import flake8cmd
from . import pr_status
from . import freeze
from . import pylintcmd
from . import release
from . import tag
from . import tag_requirements
Expand Down
8 changes: 0 additions & 8 deletions acsoo/cfg/flake8.cfg

This file was deleted.

8 changes: 0 additions & 8 deletions acsoo/cfg/flake8__init__.cfg

This file was deleted.

113 changes: 0 additions & 113 deletions acsoo/cfg/pylint.cfg

This file was deleted.

71 changes: 0 additions & 71 deletions acsoo/flake8cmd.py

This file was deleted.

Loading

0 comments on commit 67357ba

Please sign in to comment.