Add project property to raster and vector layer model #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can now confirm - from local testing - that the changes in this PR fix the issue with the RasterInfoModel and latest GRASS GIS 8.4 that were caused by renaming of location to project (which added a new "project" item to the output)... For the time being I deploy actinia API from my fork, but it would be nice to have a version of acinia ready, that can work with GRASS GIS 8.4 once that comes out... I can collect more fixes if issues arrieve, but I guess the renaming in GRASS GIS should propagate to actinia at one point... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new property
projectto the data model of vector_layer and raster_layer.It is needed to follow up: https://github.com/orgs/OSGeo/projects/2/views/1
I understand that the renaming needs significantly more changes, but actinia fails with latest GRASS GIS 8.4. and I would like to use the combination of those two...
Please let me know how the renaming should be done (e.g. in terms of versioning) in order to have the API to support both GRASS GIS 8.3 and 8.4...
Should I work with my fork for the time being?