Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry connection errors on credentials requests #2957

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Conversation

nvoxland-al
Copy link
Contributor

🚀 🚀 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Retry calls to get credentials from the backend 5 times if a connection error occurs

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
deeplake/client/client.py 45.45% 6 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link

sonarcloud bot commented Sep 23, 2024

@nvoxland-al nvoxland-al merged commit c55c1c5 into main Sep 24, 2024
9 of 10 checks passed
@nvoxland-al nvoxland-al deleted the retry_get_creds branch September 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants