-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Worldpay: update authorize request for AFT #5411
base: master
Are you sure you want to change the base?
Conversation
279b657
to
a967ede
Compare
CER-2099 Update authorize request to include AFT fields when 3DS is invoked. Previous test cases cover this change, so no further tests are necessary.
a967ede
to
a75781c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @rachelkirk I was thinking about this change some more, related to 3DS scenario that led us here, and I'm wondering if we need to add some additional logic to the aft_request
method to fully enable this to be compatible with the 3DS flow.
I notice that the build_aft_request
method looks like a truncated version of build_authorization_request
- outside of the aft_data
bits, the authorize logic has all the same sub-methods, and then some. In particular, it seems relevant that add_additional_3ds_data
and add_3ds_exemption
are present in the authorize step but missing from the build_aft_request
logic.
Is it naive to assume that simply adding those two sub-methods into the AFT logic would cover our bases for this AFT/SCA scenario? Could we write a remote test to validate that these request components will play nicely together?
One other thing that came to me as I was tinkering with the existing implementation in Postman: I think the WP docs undersold how many fields they will enforce the "can't be blank or empty" validation that previously forced us to adjust the handling of I tried to vet this theory by commenting out various lines of the
also:
|
CER-2099
Update authorize request to include AFT fields when 3DS is invoked. Previous test cases cover this change, so no further tests are necessary.